Upgrade react-router to resolve GHSA-qwww-vcr4-c8h2 - #605
Merged
Conversation
cigamit
added
dependencies
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- awx/ui/package-lock.json: Generated file
Comments suppressed due to low confidence (2)
awx/ui/package.json:7
package.jsonbumps the Node engine to ">=22.22.0", butpackage-lock.jsonstill records the root package engine as ">=22.19.0" (underpackages[""]). This suggests the lockfile wasn’t fully regenerated after the engine change, which can cause confusing engine warnings and inconsistent local installs.
Regenerate package-lock.json with the intended Node version so the root packages[""] -> engines matches package.json.
"engines": {
"node": ">=22.22.0"
},
awx/ui/package-lock.json:31
- This repo’s review guidelines require using pnpm for Node projects. Updating
package-lock.jsonkeeps the UI on npm and makes it harder to enforce a single package manager.
Consider switching awx/ui to pnpm (add pnpm-lock.yaml, remove package-lock.json, and update any build/docs references such as the UI Dockerfile / CI scripts accordingly).
cigamit
changed the title
cigamit
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 2 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- awx/ui/package-lock.json: Generated file
Comments suppressed due to low confidence (2)
awx/ui/package-lock.json:31
- This PR continues to update/commit an npm-generated lockfile (package-lock.json). Repo guidelines require using pnpm for Node projects; consider migrating to pnpm (commit pnpm-lock.yaml) and dropping package-lock.json to avoid diverging dependency resolution.
awx/ui/package-lock.json:30 - package-lock.json is inconsistent with package.json for root dependencies: package.json declares dompurify as ^3.4.12, but package-lock.json still records dompurify as ^3.4.11. This usually indicates the lockfile wasn’t fully regenerated after dependency changes, which can cause noisy diffs and non-reproducible installs.
TheWitness
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.