Pin GitHub Actions to SHAs [SRE-1802] - #10
Draft
tylergohl wants to merge 3 commits into
Draft
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
Pull request overview
This PR hardens the repository’s GitHub Actions supply chain by replacing mutable action tags with immutable commit SHAs across the repo’s workflows, aligning with SRE-1802.
Changes:
- Pinned
actions/checkoutto a specific commit SHA in all workflows. - Pinned
actions/setup-pythonto a specific commit SHA in all workflows. - Retained the prior major version reference as an inline comment (e.g.,
# v2) for readability.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| .github/workflows/build-latest.yml | Pins actions/checkout and actions/setup-python to immutable SHAs for the build/push workflow. |
| .github/workflows/ci.yml | Pins actions/checkout and actions/setup-python to immutable SHAs for both CI jobs (Podman + Docker). |
| .github/workflows/release.yml | Pins actions/checkout and actions/setup-python to immutable SHAs for the release workflow. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+13
to
+15
| - uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 | ||
|
|
||
| - uses: actions/setup-python@v2 | ||
| - uses: actions/setup-python@e9aba2c848f5ebd159c070c61ea2c4e2b122355e # v2 |
Comment on lines
+17
to
+19
| - uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 | ||
|
|
||
| - uses: actions/setup-python@v2 | ||
| - uses: actions/setup-python@e9aba2c848f5ebd159c070c61ea2c4e2b122355e # v2 |
Comment on lines
+36
to
+38
| - uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 | ||
|
|
||
| - uses: actions/setup-python@v2 | ||
| - uses: actions/setup-python@e9aba2c848f5ebd159c070c61ea2c4e2b122355e # v2 |
Comment on lines
+17
to
+19
| - uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2 | ||
|
|
||
| - uses: actions/setup-python@v2 | ||
| - uses: actions/setup-python@e9aba2c848f5ebd159c070c61ea2c4e2b122355e # v2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pin GitHub Actions references in this repo to immutable commit SHAs (with the original tag/branch preserved in a trailing comment). Part of SRE-1802 — org-wide supply-chain hardening.
Scope
This PR pins:
ctrliq/*reusable workflow and action referencesNo actions in this repo were claimed by clo-ciq's effort — this PR pins everything.
Files touched
.github/workflows/build-latest.yml.github/workflows/ci.yml.github/workflows/release.ymlTest plan
sha_pinning_requiredcan be enabled on it