Allow to disable testing of view/pure function, except prefix ones in property mode#1552
Open
gustavo-grieco wants to merge 3 commits into
Open
Allow to disable testing of view/pure function, except prefix ones in property mode#1552gustavo-grieco wants to merge 3 commits into
gustavo-grieco wants to merge 3 commits into
Conversation
gustavo-grieco
force-pushed
the
dev-disable-pureview
branch
from
7076e2f to
95ba40c
Compare
- default.yaml: add excludeViewPure (the config test requires every option be listed; it was failing with 'unset options: fromList ["excludeViewPure"]') - Tests/Integration: pin basic/excludeviewpure.sol to solc >= 0.8.0 (pragma ^0.8.0), so it is skipped on the <0.8 solc CI matrix instead of failing to compile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
elopez
reviewed
Jun 17, 2026
Comment on lines
+41
to
+42
| [ ("view property must not be excluded and should be solved", solved "echidna_counter_small") | ||
| ] |
Member
There was a problem hiding this comment.
It would be nice if this asserted somehow that the view functions are not called. Maybe add an assert(false); on a view function to make sure nobody calls it?
Comment on lines
+236
to
+242
| notPresent :: Text -> (Env, WorkerState) -> IO Bool | ||
| notPresent n (env, _) = do | ||
| tests <- traverse readIORef env.testRefs | ||
| pure $ case getResult n tests of | ||
| Nothing -> True | ||
| _ -> False | ||
|
|
Member
There was a problem hiding this comment.
This appears to be unused, please remove it if not needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1351