app: clone module account permissions - #2221
zjubiology wants to merge 1 commit into
Conversation
|
@zjubiology your pull request is missing a changelog! |
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthrough
ChangesMacc permissions copy
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to This refactor does not change permission-map behavior and is suitable to merge. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
54694bc to
d1b50ab
Compare
Signed-off-by: zjubiology <zjubiology@outlook.com>
d1b50ab to
b1c86b9
Compare
|
@JayT106 I’ve updated the PR to match the repository conventions:
The branch should now be ready for review when you have a chance. Thanks! |
Return a clone of the module-account permission map with
maps.Cloneinstead of rebuilding it manually.This preserves the defensive-copy behavior, makes ownership explicit, and avoids exposing shared configuration to caller mutation.
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit