feedback from latest session : docker / traefik#20
Open
buixor wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CrowdSec Docker and Traefik/AppSec documentation based on a recent hands-on session, focusing on persistence, container-recreate behavior, and safer Traefik bouncer key handling.
Changes:
- Documented why
/etc/crowdsec(config) and/var/lib/crowdsec/data(DB) must both be persisted in Docker deployments, and clarified the effects of container recreation. - Added a Docker-specific console enrollment pitfall (loss of enrollment state when
/etc/crowdsecisn’t persisted). - Expanded Traefik bouncer docs with file-based key support (
crowdsecLapiKeyFile) and additional AppSec failure/unreachable behavior options.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| skills/crowdsec/references/install/docker.md | Updates Docker compose guidance (writable acquis.d) and adds persistence rationale for config/data volumes. |
| skills/crowdsec/references/install/console.md | Clarifies Docker enrollment persistence requirements and adds a “recreate un-enrolls you” pitfall. |
| skills/crowdsec/references/configure/bouncers/web-servers.md | Enhances Traefik plugin configuration guidance, including secrets-based key loading and AppSec failure-mode options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+107
to
+109
| the enrollment — you re-enroll and re-Accept. Persist `/etc/crowdsec` (see | ||
| [../install/docker.md](../install/docker.md)), or use the `ENROLL_KEY` env | ||
| instead: it re-runs on every boot and is recreate-safe. |
Comment on lines
+369
to
+372
| - **Fail-open by default on AppSec trouble:** if AppSec errors or is unreachable, whether the | ||
| request is blocked depends on `crowdsecAppsecFailureBlock` / `crowdsecAppsecUnreachableBlock`. | ||
| Set both `true` to fail **closed** (a request 403s while AppSec is down) rather than pass | ||
| traffic through un-inspected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.