fix: report failed backup monitoring when the backup never starts - #676
Open
MarcWort wants to merge 2 commits into
Open
fix: report failed backup monitoring when the backup never starts #676MarcWort wants to merge 2 commits into
MarcWort wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #676 +/- ##
==========================================
+ Coverage 81.76% 81.78% +0.02%
==========================================
Files 161 161
Lines 12009 12013 +4
==========================================
+ Hits 9818 9824 +6
+ Misses 1692 1689 -3
- Partials 499 500 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A backup that aborts before restic begins because of failed run-before or immediate exit from stdin left the previous result in the prometheus metrics file, so dashboards and alerting kept showing a healthy backup even after a failure.
How it works
Both abort points now report the failure through the existing
r.summary(...)plumbing, so the monitoring receivers write the failed status.The
*_bytes/*_files/*_dirgauges are written as0on an interrupted backup because restic's completion summary is never printed.Disclaimer:
I used a selfhosted qwen3.8:27b with opencode while also trying it myself. I would have done the same changes but with somewhat diffrent tests.
Let me know what you think.