feat: Add basic math in templates and use it for checks read-data - #675
Open
MarcWort wants to merge 1 commit into
Open
feat: Add basic math in templates and use it for checks read-data#675MarcWort wants to merge 1 commit into
MarcWort wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #675 +/- ##
==========================================
- Coverage 81.76% 81.73% -0.03%
==========================================
Files 161 161
Lines 12009 12024 +15
==========================================
+ Hits 9818 9827 +9
- Misses 1692 1698 +6
Partials 499 499
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Contributor
Author
|
Added some more tests in 1af1a95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I needed a way to do monthly scans on part of my repositories, which required the modulo operation. While working on it, I thought some basic math template functions would be cleaner than the current, fairly hacky workaround described in the docs.
Let me know what you think, and if anything needs to change.
Thank you for this awesome project.