Skip to content

test(schedule): ignore pre-existing schedules in the final assertion #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
l1a wants to merge 1 commit into from
Closed

test(schedule): ignore pre-existing schedules in the final assertion #672

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions schedule/handler_systemd_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,16 +111,7 @@ func TestReadingSystemdScheduled(t *testing.T) {
scheduled, err := handler.Scheduled("")
require.NoError(t, err)

testScheduled := make([]Config, 0, len(scheduled))
for _, s := range scheduled {
if s.ConfigFile != "config file.yaml" && s.ConfigFile != "examples/dev.yaml" {
t.Logf("Ignoring config file %s", s.ConfigFile)
continue
}
testScheduled = append(testScheduled, s)
}

assert.ElementsMatch(t, expectedJobs, testScheduled)
assert.ElementsMatch(t, expectedJobs, onlyTestSchedules(t, scheduled))

// now delete all schedules
for _, testCase := range testCases {
Expand All @@ -130,7 +121,23 @@ func TestReadingSystemdScheduled(t *testing.T) {

scheduled, err = handler.Scheduled("")
require.NoError(t, err)
assert.Empty(t, scheduled)
assert.Empty(t, onlyTestSchedules(t, scheduled))
}

// onlyTestSchedules keeps the schedules created by this test and drops everything else.
// Scheduled() reads the real user unit directory, so on a machine that actually uses
// resticprofile it also returns the developer's own schedules.
func onlyTestSchedules(t *testing.T, scheduled []Config) []Config {
t.Helper()
filtered := make([]Config, 0, len(scheduled))
for _, s := range scheduled {
if s.ConfigFile != "config file.yaml" && s.ConfigFile != "examples/dev.yaml" {
t.Logf("Ignoring config file %s", s.ConfigFile)
continue
}
filtered = append(filtered, s)
}
return filtered
}

func TestDetectPermissionSystemd(t *testing.T) {
Expand Down