Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposes a unified correction API for p-values and existing permutation nulls, plus a dedicated one-sample permutation-inference entry point and thin BrainData facade. Preserves the existing t-test dictionaries and threshold methods.
The design defines result records, family/tail semantics, cluster and TFCE scope, backend acceptance criteria, bounded-memory execution, compatibility, and tests. General inference stays in nltools; course simulations may live in dartbrains-tools. This PR contains a specification only and does not authorize or implement the new API.
Validation:
uv run --no-sync poe okpassed (1,244 tests, 1 skipped); local Markdown links, code fences, placeholder scan, andgit diff --checkpassed.