Skip to content

Meson as build system, setup documentation, formatting and other other software management#4

Merged
JaroCamphuijsen merged 78 commits into
mainfrom
main
Jul 8, 2026
Merged

Meson as build system, setup documentation, formatting and other other software management#4
JaroCamphuijsen merged 78 commits into
mainfrom
main

Conversation

@JaroCamphuijsen

@JaroCamphuijsen JaroCamphuijsen commented May 21, 2026

Copy link
Copy Markdown
Member

This PR merges the fork from the NLeSC organisation into this root repository, the changes have already been reviewed in their respective pull requests.

The following changes are included in this merge:

Update the random number generator
#47 by cantordust Member was merged on Jul 8

Fixed multimap type
#46 by cantordust was merged on Jul 7

Removed a formatting option from .clang-format
#44 by cantordust Member was merged on Jun 30

Meson build instructions
#42 by cantordust Member was merged on Jun 30

Remove the dependency on Boost
#35 by cantordust was merged on May 20

Add initial citation file with authors
#33 by JaroCamphuijsen was merged on May 6

Apply clang-format to the existing code.
#32 by cantordust was merged on Apr 20

Refactor codebase to silence all compiler warnings
#27 by cantordust was merged on Apr 14

Added a clang-format configuration.
#26 by cantordust was merged on Apr 14

Added initial .gitignore file
#18 by cantordust was merged on Apr 14

Meson as build system
#9 by cantordust was merged on Apr 8

Hierarchical codebase
#8 by cantordust was merged on Apr 8

Setup sphinx documentation
#7 by JaroCamphuijsen was merged 2 weeks ago

	- Header files under `include`
	- Source files under `src`
	- Configuration files under `config`
	- Input data files under `data`
	- Other files (for now, only logos) under `assets`
	- Python files under `bindings`
TODO
====

- Update `README.md` with instructions on how to compile the source with meson.
…le and run `corticalsim3D`:

	- Updated the instructions for installing dependencies on Windows (to be verified).
	- Added instructions on setting up and compiling `corticalsim3D`.
	- Added a Run section (to be updated).
	- Note: This is a working file, it could change drastically over time.
NOTE: This needs to be refactored to eliminate initialisations inside case statements.
JaroCamphuijsen and others added 24 commits April 28, 2026 11:42
Thanks for the review! These were all reasonable suggestions. Most of the text in "introduction.md" actually came from the referenced paper, so the text fixes should be in there. For me this is a placeholder anyway, as I think Eva and/or Bandan should write these parts. For now i just accepted your contributions, which made it more readable.

Co-authored-by: Alexander Hadjiivanov <43831101+cantordust@users.noreply.github.com>
Add initial citation file with authors
…eck will be removed when the Boost dependency is removed.
…s causing earlier versions of Clang to throw an error.
	- Using only STL components (`std::mt19937_64`, various distributions).
	- Removed unused methods.
	- Renamed the `MTRand` class to a more generic `RandHub` since the RNG engine can be replaced in the future.
	- Renamed `MersenneTwister.h` to `randhub.hpp` to reflect the renamed class.
…warnings. These need to be handled properly (see issue 29).
Removed a formatting option from `.clang-format`
Update the random number generator
@JaroCamphuijsen JaroCamphuijsen changed the base branch from develop to main July 8, 2026 11:27

@cantordust cantordust left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge-worthy!☺️

@JaroCamphuijsen JaroCamphuijsen merged commit 9af92d3 into corticalsim:main Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants