adds field for specifying assets URLs for thumbnails - #11276
Open
Mike Reynolds (MikeDReynolds68) wants to merge 1 commit into
Open
adds field for specifying assets URLs for thumbnails#11276Mike Reynolds (MikeDReynolds68) wants to merge 1 commit into
Mike Reynolds (MikeDReynolds68) wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This branch includes the following changes:
assetsUrlRootwhich allows customers to set the root to be used when generating asset thumbnail URLstransformAssetsfunction to accept aconfigparameter and use itsassetsUrlRootproperty to modify each asset'sthumbUrlif not nullrepositoryId,aemTierType, andenvfrom thecontentAdvisorPropsobject instantiation and makes them conditionalrepositoryId,aemTierType, andenvin thesetupfunction to clarify their conditional usagerepositoryId,aemTierType, andenvand addsassetsUrlRootin the Installation Parameters table of theREADME.mdfileApproach
The addition of the
assetsRootUrlfield was necessary to allow Ralph Lauren to generate a valid thumbnail URL for assets selected from their author environment which does not provide publicly accessible asset URLs.The change to
repositoryId,aemTierTypeandenvwas made to prevent the app from passing conflicting configuration parameters to the AEM Content Advisor micro front-end.Testing steps
Test 1: Enter a valid AEM Assets base URL in the
assetsUrlRootand save the configuration. Open a content entry that uses the AEM Assets connector and click the button labeled 'Select assets from AEM'. Click on an asset in the Content Advisor modal window and then click the button labeled 'Select' in the top right corner. Inspect the thumbnail image generated by the AEM Assets connector and verify the asset URL base matches the value of theassetsUrlRootconfiguration parameter.Breaking Changes
None
Dependencies and/or References
None
Deployment
None