Skip to content

ci: declare workflow-level contents: read on 2 workflows#4906

Open
arpitjain099 wants to merge 1 commit into
containerd:mainfrom
arpitjain099:chore/declare-workflow-perms-readonly
Open

ci: declare workflow-level contents: read on 2 workflows#4906
arpitjain099 wants to merge 1 commit into
containerd:mainfrom
arpitjain099:chore/declare-workflow-perms-readonly

Conversation

@arpitjain099
Copy link
Copy Markdown

Pins the default GITHUB_TOKEN to contents: read on 2 workflows in .github/workflows/ that don't call a GitHub API beyond the initial checkout.

The following files were left implicit because they reference GITHUB_TOKEN / use a write-scope action / trigger on pull_request_target. Those scopes are best declared by maintainers: workflow-flaky.yml, workflow-tigron.yml.

Why

CVE-2025-30066 (March 2025 tj-actions/changed-files supply-chain compromise) exfiltrated GITHUB_TOKEN from workflow logs. Pinning per workflow caps runtime authority irrespective of the repo or org default, gives drift protection if the default ever widens, and is credited per-file by the OpenSSF Scorecard Token-Permissions check.

YAML validated locally with yaml.safe_load on each touched file.

Pins the default GITHUB_TOKEN to contents: read on the workflows in
.github/workflows/ that don't call a GitHub API beyond the initial
checkout. The other workflows in this directory are left implicit
because they need write scopes that a maintainer is better placed
to declare.

Motivation: CVE-2025-30066 (March 2025 tj-actions/changed-files
compromise) exfiltrated GITHUB_TOKEN from workflow logs. Per-workflow
caps bound runtime authority irrespective of repo or org default,
give drift protection if the default ever widens, and are credited
per-file by the OpenSSF Scorecard Token-Permissions check.

YAML validated locally with yaml.safe_load.

Signed-off-by: Arpit Jain <arpitjain099@gmail.com>
@AkihiroSuda
Copy link
Copy Markdown
Member

trigger on pull_request_target.

I don't think we have a workflow that is triggered on pull_request_target?

@sathiraumesh
Copy link
Copy Markdown
Contributor

trigger on pull_request_target.

I don't think we have a workflow that is triggered on pull_request_target?

@AkihiroSuda This PR is about improving security through preventing default token permission cascade which here prevents writes and only makes read permissions which makes the least privilege principle on the actions

@AkihiroSuda
Copy link
Copy Markdown
Member

trigger on pull_request_target.

I don't think we have a workflow that is triggered on pull_request_target?

@AkihiroSuda This PR is about improving security through preventing default token permission cascade which here prevents writes and only makes read permissions which makes the least privilege principle on the actions

Your reply doesn't seem to answer my question.

@AkihiroSuda
Copy link
Copy Markdown
Member

@arpitjain099

May I ask if you are a human or a bot?

You seem to have submitted 445 PRs just in 3 days: https://github.com/pulls?q=is%3Apr+author%3Aarpitjain099+created%3A2026-05-13..2026-05-15+

@arpitjain099
Copy link
Copy Markdown
Author

@arpitjain099

May I ask if you are a human or a bot?

You seem to have submitted 445 PRs just in 3 days: https://github.com/pulls?q=is%3Apr+author%3Aarpitjain099+created%3A2026-05-13..2026-05-15+

@AkihiroSuda Not a bot, I am using automation but all the PRs I am working upon cover similar improvements across multiple repos and I individually vet each PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants