Repository navigation
fix(deploy): validate declared manifest environment variables - #231
Merged
Merged
Conversation
silviot
marked this pull request as ready for review
September 7, 2026 09:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manifest declaration checks previously accepted the app’s top-level
<name>or a<name>inside an XML comment, allowing undeclared deploy values that AppAPI silently drops. The shared helper now checks names within<environment-variables>after removing XML comments, with regressions for both false positives.This PR follows the D-729 repository split: the helper and its tests remain at
scripts/lib-exapp-register.shandscripts/test-exapp-register.sh. The production--envdriver changes and staging tests are now in https://github.com/codemyriad/systems/pull/11. Main has been merged and the deletedops/deploydriver files are not restored.Validation passed:
bash -n scripts/lib-exapp-register.sh scripts/test-exapp-register.shshellcheck -x scripts/lib-exapp-register.sh scripts/test-exapp-register.shscripts/test-exapp-register.sh./scripts/fold-changelog.sh --version 0.3.0-alpha.1 --checkpasses for all repository fragments.Also corrects the missing heading and bullet in
changelog.d/ci-recorder-selectivity.mdso the full changelog validation succeeds.No live deployment was performed.