Repository navigation
a11y: label injected controls and preserve native focus - #4334
Draft
imparable2022 wants to merge 3 commits into
Draft
imparable2022 wants to merge 3 commits into
imparable2022 wants to merge 3 commits into
Conversation
This was referenced Sep 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked PR
Depends on #4333 (and therefore #4332). This PR is a draft while the preceding accessibility layers are reviewed.
The new change to review here is commit
45e6b2fc5828c1807e1d1eaa1141872c54fe2149.Problem
ImprovedTube injects icon-only/custom controls into YouTube that do not always expose stable accessible names. Separately, upstream code temporarily replaces
HTMLElement.prototype.focus, which can interfere with keyboard and screen-reader focus at a global page level.What changes
Page-world accessibility
js&css/web-accessible/accessibility.jsWiring
manifest.jsonweb-accessible resourcesinit.jsPreserve native focus
ImprovedTube.forbidFocus(2100)usageHTMLElement.prototype.focusreplacement inappearance.jsshortcuts.jsfrom assigningHTMLElement.prototype.focusas part of that workaroundThe injected-control module is additive. The focus-safety part restores native browser focus semantics rather than introducing another focus model.