feat: add max_summary_length config option (#127) - #201
Draft
kimjune01 wants to merge 3 commits into
Draft
Conversation
Implements configurable character limit for commit summaries. - Add max_summary_length field to Config, ConfigTOML, and ConfigArgs - Add validate_summary_with_max_length function with length checking - Wire max_summary_length through prompt_summary to validator - Add CLI flag --max-summary-length for runtime override - Add comprehensive tests for validation and config loading - Default behavior unchanged (no limit unless configured) Closes cococonscious#127
The old validate_summary function became dead code when validate_summary_with_max_length replaced it. Updated the test to call the new function with None (equivalent behavior).
kimjune01
marked this pull request as draft
May 18, 2026 06:06
Author
|
PR lacks a test exercising the change, so drafting. Please close or take it over. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_summary_lengthconfiguration option to limit commit summary length.koji.toml(max_summary_length = 72) and CLI (--max-summary-length 72)chars().count()for correct Unicode handlingFixes #127
Test plan
cargo clippyclean,rustfmtapplied