Repository navigation
feat(ui): add messages-and-notifications intent skill set - #2195
Open
franzheidl wants to merge 2 commits into
Open
franzheidl wants to merge 2 commits into
franzheidl wants to merge 2 commits into
Conversation
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
🦋 Changeset detectedLatest commit: 68783ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
franzheidl
marked this pull request as ready for review
November 20, 2026 10:59
…essages-and-notifications specs Signed-off-by: Franz Heidl <franz.heidl@sap.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a messages-and-notifications intent skill set.
Changes Made
Adds a third Intent skill set,
messages-and-notifications, to@cloudoperators/juno-ui-components, alongside the existingdatagridandstatussets. It covers Juno's two feedback mechanisms: 1.)Message(static, inline) andToast/NotificationManager(transient, via thetoast()API), and 2.) the decision for choosing between them.It also closes a gap in
status-spec, which pointed readers at "dedicated components (Toast,Message)" without defining their correct use. The rule set is lifted from the existing UX docdocs/ux/messages-and-notifications.md.What's included
messages-and-notifications-spec— the single source of truth: the two-mechanism model, the Message-vs-Notification selection table, theMessageand notification APIs, and invariantsMN-1–MN-10.messages-and-notifications-build— generates correct usage from a described situation.messages-and-notifications-validate— audits an existing usage and reportsMN-*violations.feedback(the first beyonddata-display).Both task skills
requirethe spec and cite its rule IDs — they never restate rules.Status boundary
status-specnow citesMN-1/MN-9at its handoff, andMN-9points back atstatus-specINV-1, so the three feedback surfaces (Status, Message, Notification) share one coherent decision model.Out of scope
Semantic variant meaning is deferred to the UX doc and a future cross-cutting
semantic-variantstopic skill; this set only cross-references it.Checks
intent validate/maintainer review/maintainer checkall pass; review outcomes recorded in.intent/review-state.json. Changeset:minor.Related Issues
Closes #2194
Testing Instructions
None as no runtime changes are included with this PR.
Checklist
PR Manifesto
Review the PR Manifesto for best practises.