Skip to content

Fix duplicate UAA and CredHub ops in Docker CI tests - #537

Merged
Alphasite merged 1 commit into
developfrom
fix-docker-ci-duplicate-uaa
Oct 29, 2026
Merged

Alphasite merged 1 commit into
developfrom
fix-docker-ci-duplicate-uaa

Conversation

@Alphasite

@Alphasite Alphasite commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

The updated docker-cpi image always applies uaa.yml and credhub.yml in start-bosh. The shared Docker test task also passes both files, so manifest generation fails when UAA tries to remove the already-removed local user configuration, as seen in test-noble-docker build 342.

Remove the duplicate arguments and retain the optional director ops files used by the Resolute job. This follows the startup change in cloudfoundry/bosh@0b569530.

Validation: reproduced the original interpolation error using the startup function read from the failed build's image. With the fix, Noble and Resolute manifest interpolation succeeds, each includes exactly one UAA and CredHub release/job, and both retain the expected stemcell. bash -n, ShellCheck, and git diff --check passed.

Live validation: one-off build 396909981 passed the complete Noble Docker task using the same image digest and Noble 1.647 stemcell as failed build 342. Director creation, UAA authentication, NATS deployment, the TLS smoke-test errand (exit 0), recreation, and cleanup all succeeded. Hijacking the running task confirmed the patched call and exactly one UAA and CredHub release/job in the generated manifest.

Copilot AI balanced review requested due to automatic review settings October 29, 2026 21:22
@coderabbitai

coderabbitai Bot commented Oct 29, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 2c0a7776-8e9d-45ea-b386-d102c9068f93

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change removing duplicate UAA and CredHub startup arguments.

No open issues 🎉

What changed in this PR

Removes duplicate UAA and CredHub ops arguments from the shared Docker CI test task, relying on start-bosh to apply them and avoiding manifest interpolation failures.

Changes:

  • Removes explicit uaa.yml and credhub.yml arguments.
  • Preserves optional director ops files used by Resolute and documents why the default ops are omitted.
File Description
ci/​tasks/​test-docker.sh Removes duplicate startup ops arguments while retaining optional director configuration.

Review effort: Balanced

@Alphasite
Alphasite merged commit 4f53b38 into develop Oct 29, 2026
4 checks passed
@Alphasite
Alphasite deleted the fix-docker-ci-duplicate-uaa branch October 29, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants