fix: show real created_at in trusted account attached general account table (CLO-1344) - #6147
Merged
seungyeoneeee merged 2 commits intoAug 3, 2026
Conversation
… table (CLO-1344) The Created column in the connected General Account list rendered dayjs(value.data), but the PDataTable format slot passes the created_at string directly as value. Accessing .data on a string yielded undefined, so dayjs(undefined) produced the current time for every row. Use dayjs(value) to format the actual created_at value. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: 이승연 <sylee1274@mz.co.kr>
…olumn (CLO-1344) Follow-up hardening from code review. This table can list PENDING accounts whose created_at may be absent; bare dayjs(value) would render 'Invalid Date' or, if undefined, silently reintroduce the current-time bug. iso8601Formatter null-guards (returns '') and uses the same 'YYYY-MM-DD HH:mm:ss' format, matching the sibling CollectorDetailAttachedServiceAccounts component. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: 이승연 <sylee1274@mz.co.kr>
|
@seungyeoneeee is attempting to deploy a commit to the cloudforet Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
🎉 @yuda110 has been randomly selected as the reviewer! Please review. 🙏 |
seungyeoneeee
added a commit
that referenced
this pull request
Aug 3, 2026
… table (CLO-1344) (#6147) * fix: show real created_at in trusted account attached general account table (CLO-1344) The Created column in the connected General Account list rendered dayjs(value.data), but the PDataTable format slot passes the created_at string directly as value. Accessing .data on a string yielded undefined, so dayjs(undefined) produced the current time for every row. Use dayjs(value) to format the actual created_at value. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: 이승연 <sylee1274@mz.co.kr> * refactor: use iso8601Formatter for attached general account Created column (CLO-1344) Follow-up hardening from code review. This table can list PENDING accounts whose created_at may be absent; bare dayjs(value) would render 'Invalid Date' or, if undefined, silently reintroduce the current-time bug. iso8601Formatter null-guards (returns '') and uses the same 'YYYY-MM-DD HH:mm:ss' format, matching the sibling CollectorDetailAttachedServiceAccounts component. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: 이승연 <sylee1274@mz.co.kr> --------- Signed-off-by: 이승연 <sylee1274@mz.co.kr> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks
seungyeoneeee
added a commit
that referenced
this pull request
Aug 3, 2026
… table (CLO-1344) (#6147) (#6148) * fix: show real created_at in trusted account attached general account table (CLO-1344) The Created column in the connected General Account list rendered dayjs(value.data), but the PDataTable format slot passes the created_at string directly as value. Accessing .data on a string yielded undefined, so dayjs(undefined) produced the current time for every row. Use dayjs(value) to format the actual created_at value. * refactor: use iso8601Formatter for attached general account Created column (CLO-1344) Follow-up hardening from code review. This table can list PENDING accounts whose created_at may be absent; bare dayjs(value) would render 'Invalid Date' or, if undefined, silently reintroduce the current-time bug. iso8601Formatter null-guards (returns '') and uses the same 'YYYY-MM-DD HH:mm:ss' format, matching the sibling CollectorDetailAttachedServiceAccounts component. --------- Signed-off-by: 이승연 <sylee1274@mz.co.kr> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLO-1344
Trusted Account 상세 페이지의 연결된 General Account 목록 데이터테이블에서
Created컬럼이 모든 행에 현재 시각으로 표시되던 버그를 수정합니다.원인
ServiceAccountAttachedGeneralAccounts.vue의#col-created_at-format="{value}"슬롯은value로created_at문자열(스칼라)을 직접 넘깁니다. 기존 코드는 존재하지 않는value.data에 접근해undefined가 되었고,dayjs(undefined)가 현재 시각을 반환해 모든 행이 동일한 현재 시간으로 표시되었습니다.수정
dayjs(value.data)...→iso8601Formatter(value, state.timezone)iso8601Formatter는 동일한YYYY-MM-DD HH:mm:ss포맷을 사용하면서 falsy 값에 대해''를 반환(null-safe)합니다. 이 테이블은created_at이 없을 수 있는 PENDING 계정도 노출하므로,dayjs(value)단독보다 안전합니다.CollectorDetailAttachedServiceAccounts.vue와 동일한 패턴입니다.검증
🤖 Generated with Claude Code