fix(ui): Add claim name for Custom SAML provider in <ConfigureSSO />#8586
Conversation
🦋 Changeset detectedLatest commit: 0a8f3f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/dev-cli
@clerk/expo
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR extends the component to add an Okta-specific claim value column to the attribute mapping table. The localization type definition gains a new claimValue field, and en-US strings are updated with the column header and example claim values. The ConfigureStep component conditionally renders the claim value column only when the provider is Okta, using the new localization keys. The TestConfigurationStep component has its Continue button's isDisabled prop removed, letting button state be controlled purely by the onClick handler and isLoading flag. Patch releases are recorded for four affected packages. Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
d4fc01a to
0a8f3f3
Compare
Description
This PR fixes the attribute statements step for Custom SAML provider, where previously was displaying the claim value with an expression that is specific to Okta
It also fixes an issue on the test step, where it was always disabling the button, but the validation actually happens on click.
Custom SAML
Okta
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change