Skip to content

chore(ui): Update NavBar to receive containerSx prop#8568

Merged
LauraBeatris merged 2 commits into
mainfrom
laura/update-sidebar-layout-order
May 18, 2026
Merged

chore(ui): Update NavBar to receive containerSx prop#8568
LauraBeatris merged 2 commits into
mainfrom
laura/update-sidebar-layout-order

Conversation

@LauraBeatris
Copy link
Copy Markdown
Member

Description

image

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@LauraBeatris LauraBeatris self-assigned this May 16, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 16, 2026

🦋 Changeset detected

Latest commit: 83be304

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@clerk/ui Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment May 18, 2026 3:09pm

Request Review

@LauraBeatris LauraBeatris changed the base branch from main to laura/orgs-1539-configuresso-support-custom-saml-provider-on-configure-step May 16, 2026 10:05
@LauraBeatris LauraBeatris marked this pull request as ready for review May 16, 2026 10:05
@LauraBeatris LauraBeatris changed the title Update NavBar flex order by forwarding sx prop chore(ui): Update NavBar to receive containerSx prop May 16, 2026
@LauraBeatris LauraBeatris changed the title chore(ui): Update NavBar to receive containerSx prop chore(ui): Update NavBar to receive containerSx prop May 16, 2026
@LauraBeatris LauraBeatris force-pushed the laura/orgs-1539-configuresso-support-custom-saml-provider-on-configure-step branch 3 times, most recently from c3e36bb to 25820ff Compare May 16, 2026 21:26
@LauraBeatris LauraBeatris force-pushed the laura/orgs-1539-configuresso-support-custom-saml-provider-on-configure-step branch 3 times, most recently from b3dd719 to c647566 Compare May 18, 2026 14:48
Base automatically changed from laura/orgs-1539-configuresso-support-custom-saml-provider-on-configure-step to main May 18, 2026 15:00
@LauraBeatris LauraBeatris force-pushed the laura/update-sidebar-layout-order branch from 3d9b478 to f6f5dd0 Compare May 18, 2026 15:07
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 18, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b2e3cf74-8b9c-4f1f-bc6a-b1fd7004d59c

📥 Commits

Reviewing files that changed from the base of the PR and between 4fc38a0 and 83be304.

📒 Files selected for processing (3)
  • .changeset/thirty-jeans-live.md
  • packages/ui/src/components/ConfigureSSO/ConfigureSSONavbar.tsx
  • packages/ui/src/elements/Navbar.tsx

📝 Walkthrough

Walkthrough

This PR extends the NavBar component with an optional containerSx prop that allows consuming components to customize the navbar container's flex layout. The prop is threaded from NavBar through NavbarContainer, where it is merged with default styles via an sx array. The NavBar component's items rendering is also refactored to conditionally render the routes button column only when routes exist. ConfigureSSONavbar demonstrates the feature by applying column-reverse stacking with flex constraints.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding a containerSx prop to the NavBar component, which aligns with all file modifications in the changeset.
Description check ✅ Passed The description relates to the changeset by including an image of the SSO configuration UI that uses the updated NavBar layout, and confirms tests and builds pass.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new Bot commented May 18, 2026

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@8568

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@8568

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@8568

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@8568

@clerk/dev-cli

npm i https://pkg.pr.new/@clerk/dev-cli@8568

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@8568

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@8568

@clerk/express

npm i https://pkg.pr.new/@clerk/express@8568

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@8568

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@8568

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@8568

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@8568

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@8568

@clerk/react

npm i https://pkg.pr.new/@clerk/react@8568

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@8568

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@8568

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@8568

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@8568

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@8568

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@8568

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@8568

commit: 83be304

@LauraBeatris LauraBeatris merged commit 3987851 into main May 18, 2026
43 checks passed
@LauraBeatris LauraBeatris deleted the laura/update-sidebar-layout-order branch May 18, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants