feat: Improve error for install with specific version#190
Conversation
Before this patch, `moonup install <specific-version>` fails with an simple error: ``` $ moonup install 0.9.3 No toolchain available for requested spec '0.9.3' ``` This patch improves the error, showing available versions near to the given version: ``` $ moonup install 0.9.3 x no release available for requested spec: 0.9.3. hint: e.g. 0.9.3+08f337e2c is available. ```
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Summary by CodeRabbit
WalkthroughThis PR changes ChangesToolchain recipe errors
Possibly related issues
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a0f5263b-984c-4536-af05-4ea61bfaee07
⛔ Files ignored due to path filters (1)
tests/e2e/snapshots/test__e2e__flow__moonup_install_specific_version_unavailable_mock.snapis excluded by!**/*.snap
📒 Files selected for processing (5)
Cargo.tomlsrc/cli/install.rssrc/cli/update.rssrc/toolchain/index.rstests/e2e/flow.rs
|
I'd love to place the hint to a new line. This way, when we add other hints later, we can keep all hints in the same format. $ moonup install 0.9.3
No release available for requested spec '0.9.3'
Hint: 0.9.3+08f337e2c is available |
|
Updated. Two versions: commit 916de59 (with commit 7b84527 (with Note that there is no Which one is better? Also, let me know if we use squash for commit. I'll fix #191 first as the test for aarch64 is failing. |
|
Ready to review this PR? Stage has broken it down into 3 individual chapters for you:
Chapters generated by Stage for commit 7b84527 on Jun 29, 2026 3:23am UTC. |
Option 1 of #189
Before this patch,
moonup install <specific-version>fails with an simple error:This patch improves the error, showing available versions near to the given version:
Note that I'm using aarch64 Linux and I need tweaks to run tests. I checked that the test passes in my environment, but it might fail.