Repository navigation
fix(docs): keep the demo's full screen view in the browser window - #1275
Merged
lcottercertinia merged 1 commit intoNov 2, 2026
Merged
Conversation
On macOS, Full screen used the browser Fullscreen API, which took over the whole desktop. The demo now fills the browser window below the navbar, so the site navigation stays usable. The announcement bar is hidden and the page cannot scroll while the demo is expanded.
lcottercertinia
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
On macOS, the live demo's Full screen button used the browser Fullscreen API. The demo took over the whole desktop as a new Space, and the docs site navigation was no longer reachable.
The demo now fills the browser window below the docs navbar. The navbar stays on top and usable, and exit puts you back at the same scroll position.
🛠️ Changes made
position: fixed; the figure keeps its place in the page — otherwise scroll anchoring jumps the page about 870px on exit.--ifm-navbar-heightwith no JS measurement.aria-expanded.🧩 Type of change (check all applicable)
📷 Screenshots / gifs / video [optional]
N/A
🔗 Related Issues
N/A
✅ Tests added?
📚 Docs updated?
🧪badge — see RELEASING.md)Anything else we need to know? [optional]
Test plan:
pnpm exec jest --selectProjects docs— 34 pass. New tests: Full screen does not callrequestFullscreen, Exit returns to the page, and close then reopen starts at page size.pnpm startinlana-docs: open the demo, then Full screen. The panel fills the window below the navbar and the Docs dropdown opens over it. Exit from scroll positions 0, 300, 600 and 900 returns to the same position. Narrow the window to 700px while expanded: Exit stays visible.Pre-existing, not fixed here:
lana-docs/src/css/custom.css:90matches the announcement bar by its hashed class (div[class^='announcementBar_']). The stable class is.theme-announcement-bar.<body>instead of the Open demo button.