Skip to content

refactor(cli): migrate releasecelo, validator, validatorgroup to viem [8/8]#773

Closed
pahor167 wants to merge 4 commits into
pahor/viem-D4-cli-commands-2from
pahor/viem-D5-cli-final
Closed

refactor(cli): migrate releasecelo, validator, validatorgroup to viem [8/8]#773
pahor167 wants to merge 4 commits into
pahor/viem-D4-cli-commands-2from
pahor/viem-D5-cli-final

Conversation

@pahor167

@pahor167 pahor167 commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

Stack

A β†’ B β†’ C β†’ D1 β†’ D2 β†’ D3 β†’ D4 β†’ D5 ← CI must be green

Changes

Replace web3-based transaction patterns with viem equivalents across releasecelo/, validator/, and validatorgroup/ CLI commands and their tests.

This is the final PR in the stack β€” CI must pass here before merging any of the chain.


PR-Codex overview

This PR focuses on refactoring the codebase to replace instances of displaySendTx with displayViemTx, updating the transaction handling mechanism to use a new client. It also modifies test cases to use a provider instead of Web3, enhancing compatibility with a new connection method.

Detailed summary

  • Replaced displaySendTx with displayViemTx in various command files.
  • Updated transaction handling to use publicClient.
  • Modified test cases to use provider instead of web3.
  • Changed newKitFromWeb3 to newKitFromProvider in tests.
  • Adjusted transaction hash handling for better compatibility.

The following files were skipped due to too many changes: packages/cli/src/commands/releasecelo/set-account.test.ts, packages/cli/src/commands/validator/affilliate.test.ts, packages/cli/src/commands/releasecelo/refund-and-finalize.test.ts, packages/cli/src/commands/validatorgroup/member.test.ts, packages/cli/src/commands/releasecelo/admin-revoke.ts, packages/cli/src/commands/validatorgroup/rpc-urls.test.ts, packages/cli/src/commands/releasecelo/set-beneficiary.test.ts, packages/cli/src/commands/validatorgroup/deregister.test.ts, packages/cli/src/commands/releasecelo/authorize.test.ts, packages/cli/src/commands/releasecelo/transfer-dollars.test.ts, packages/cli/src/commands/releasecelo/withdraw.test.ts, packages/cli/src/commands/releasecelo/admin-revoke.test.ts, packages/cli/src/commands/validator/deregister.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

…s to viem

Replace web3-based transaction patterns with viem equivalents across
releasecelo/, validator/, and validatorgroup/ CLI commands and their tests.
@pahor167 pahor167 requested a review from a team as a code owner April 1, 2026 09:08
@changeset-bot

changeset-bot Bot commented Apr 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0db402d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Apr 1, 2026

Copy link
Copy Markdown
Contributor

size-limit report πŸ“¦

Path Size
import * from '@celo/core' (csj) 1.81 KB (0%)
import * from '@celo/core' (esm) 1.56 KB (0%)

@codecov

codecov Bot commented Apr 1, 2026

Copy link
Copy Markdown

Codecov Report

βœ… All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (pahor/viem-D4-cli-commands-2@289b880). Learn more about missing BASE report.

Additional details and impacted files
@@                       Coverage Diff                       @@
##             pahor/viem-D4-cli-commands-2     #773   +/-   ##
===============================================================
  Coverage                                ?   66.69%           
===============================================================
  Files                                   ?      167           
  Lines                                   ?     8200           
  Branches                                ?     1369           
===============================================================
  Hits                                    ?     5469           
  Misses                                  ?     2660           
  Partials                                ?       71           
Components Coverage Ξ”
celocli 58.89% <0.00%> (?)
sdk 66.09% <0.00%> (?)
wallets 73.02% <0.00%> (?)
viem-sdks 94.15% <0.00%> (?)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pavel Hornak added 3 commits April 1, 2026 12:04
…shot

- SimpleHttpProvider.request: add replacer to JSON.stringify that converts
  bigint to hex string, fixing "Do not know how to serialize a BigInt" when
  viem passes bigint blockNumber params via the provider
- election/activate.test.ts: update inline snapshots to reflect correct
  sequential tx log order (finishNextEpoch txHash arrives before activate starts)
- Remove extra trailing txHash entry from two activate --wait snapshots
  (displayViemTx only emits one txHash per call, not two)
- Increase reorders member beforeEach/test timeouts from 30s to 60s
- Add 60s timeout to epoch block information tests (viem adds pre-flight
  gas estimation making each write ~50% more RPC calls than web3)
pahor167 added a commit that referenced this pull request Jun 15, 2026
…es (#780)

## Summary

Combined branch containing the full web3 β†’ viem migration (the union of
the stacked PRs #766–#773) plus 24 commits of review fixes from a deep
multi-agent audit of the cumulative diff (~350 files).

### Migration (from the original stack)
- `@celo/connect`, `@celo/utils`: web3 replaced with viem-native
primitives (#766)
- `@celo/contractkit`: viem-native contract interaction across all
wrappers (#767)
- `@celo/explorer`, `@celo/governance`, wallets, dev-utils (#768)
- `@celo/celocli`: all command groups migrated (#769–#773)

### Review fixes on top (highlights, 38 findings fixed)

Funds/correctness critical:
- wallet-base: tx quantities above 2^53 were silently truncated when
hex-encoding (`1 CELO + 1 wei` signed as exactly 1 CELO); now
BigInt-backed with a regression test
- connect: `defaultFeeCurrency` was silently ignored for every
`contract.write`; dynamic chain now carries the Celo
serializers/formatters so CIP-64 serializes correctly
- contractkit: IPC provider hung forever (parsed only on socket `end`);
ws:// / wss:// node URLs fell through to the HTTP provider; HTTP error
statuses resolved `undefined`
- contractkit: `setAccount` without proof-of-possession always threw
(`'0x0'` as bytes32); `Attestations.getPendingWithdrawals` parameter
order restored to match the contract
- cli: `releasecelo:admin-revoke` lost the `{from: voteSigner}` override
β†’ revokes reverted with an authorized vote signer
- connect: fee-math radix bug inflated `maxFeePerGas` for string inputs

High:
- tuple-blind ABI signatures produced wrong selectors/topic hashes (ABI
enrichment, `methodIds`, log-explorer event matching)
- `BaseWrapper.getPastEvents` swallowed RPC errors as "no events";
unknown event names now throw (web3 parity)
- Election historical `blockNumber` queries were silently ignored (voter
rewards at past epochs)
- governance CLI commands no longer displayed on-chain event
confirmations (ProposalExecuted / HotfixExecuted / HotfixApproved /
Deposit) β€” restored, including the silently-dropped test snapshots
- `isValidChecksumAddress` accepted all-lowercase addresses; sourcify
proxy implementation address checksummed again
- BigInt-safe JSON-RPC serialization in production providers

Plus test-semantics restorations (weakened assertions,
mocked-method-under-test), test-infra robustness (receipt waits, strict
`evm_revert`), changeset corrections (contractkit correctly marked major
with full breaking-change list), and documentation of behavior changes.

Full audit trail (62 findings: 38 fixed, 12 refuted with evidence, the
rest classified pre-existing/wontfix) lives in
`.omc/ralph/pr-review-progress.md` on the working machine; findings are
also traceable through the individual commit messages.

## Test plan
- [x] Full workspace build green (all 23 packages)
- [x] Full test suite: all packages green locally except known env-flaky
timeouts under full parallel load (actions/keystores) and a pre-existing
`election:activate --wait` snapshot-order flake that reproduces on the
unmodified stack HEAD
- [x] Anvil-backed suites green: contractkit 258/258, celocli 337 passed
- [x] Live smoke tests: IPC provider against `anvil --ipc`, WebSocket
provider against `wss://forno.celo.org/ws`
- [ ] CI green on this PR

---------

Co-authored-by: Pavel Hornak <pavel.hornak@clabs.co>
Co-authored-by: Paul Lange <palango@gmx.de>
@pahor167 pahor167 closed this Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant