refactor(connect,utils): replace web3 with viem [1/8]#766
Conversation
- Delete rpc-caller.ts, celo-transaction-object.ts, tx-result.ts, promi-event - Add contract-types.ts (CeloContract<TAbi>), viem-abi-coder.ts, wallet-adapter.ts - Replace web3 ABI types with viem-native equivalents in abi-types.ts - Rewrite connection.ts internals to use viem client - Remove BigNumber/bn.js from utils — use native bigint in solidity.ts, signatureUtils.ts, ecies.ts - Remove @ethereumjs/* dependencies - Patch buffer-equal-constant-time for Node 25 compatibility - Drop web3 from yarn.lock
🦋 Changeset detectedLatest commit: 05fceb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 05fceb7606
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| debugPayload('%O', payload) | ||
| request: EIP1193RequestFn = async ({ method, params }) => { | ||
| const safeParams: any[] = Array.isArray(params) ? params : params != null ? [params] : [] |
There was a problem hiding this comment.
The new request implementation always coerces non-array params into an array ({...} becomes [{...}]), but EIP-1193 allows object-form params and some RPC methods require that exact shape. In those cases (for example wallet-management methods), forwarding through CeloProvider will send malformed params and the upstream provider will reject the call, breaking consumers that call connection.currentProvider.request(...) with object params.
Useful? React with 👍 / 👎.
| const isOverrides = | ||
| lastArg != null && typeof lastArg === 'object' && !Array.isArray(lastArg) |
There was a problem hiding this comment.
The proxy assumes any last argument that is an object is a transaction overrides object, but viem tuple/struct arguments are also plain objects. For contract write methods whose final ABI argument is a tuple, this path can incorrectly treat that tuple as overrides, injecting/removing fields like account/chain on user data and skipping proper overrides placement, which can cause write calls to fail or send with unintended account handling.
Useful? React with 👍 / 👎.
Code reviewFound 1 issue:
developer-tooling/packages/sdk/utils/src/signatureUtils.ts Lines 85 to 92 in 05fceb7 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
…es (#780) ## Summary Combined branch containing the full web3 → viem migration (the union of the stacked PRs #766–#773) plus 24 commits of review fixes from a deep multi-agent audit of the cumulative diff (~350 files). ### Migration (from the original stack) - `@celo/connect`, `@celo/utils`: web3 replaced with viem-native primitives (#766) - `@celo/contractkit`: viem-native contract interaction across all wrappers (#767) - `@celo/explorer`, `@celo/governance`, wallets, dev-utils (#768) - `@celo/celocli`: all command groups migrated (#769–#773) ### Review fixes on top (highlights, 38 findings fixed) Funds/correctness critical: - wallet-base: tx quantities above 2^53 were silently truncated when hex-encoding (`1 CELO + 1 wei` signed as exactly 1 CELO); now BigInt-backed with a regression test - connect: `defaultFeeCurrency` was silently ignored for every `contract.write`; dynamic chain now carries the Celo serializers/formatters so CIP-64 serializes correctly - contractkit: IPC provider hung forever (parsed only on socket `end`); ws:// / wss:// node URLs fell through to the HTTP provider; HTTP error statuses resolved `undefined` - contractkit: `setAccount` without proof-of-possession always threw (`'0x0'` as bytes32); `Attestations.getPendingWithdrawals` parameter order restored to match the contract - cli: `releasecelo:admin-revoke` lost the `{from: voteSigner}` override → revokes reverted with an authorized vote signer - connect: fee-math radix bug inflated `maxFeePerGas` for string inputs High: - tuple-blind ABI signatures produced wrong selectors/topic hashes (ABI enrichment, `methodIds`, log-explorer event matching) - `BaseWrapper.getPastEvents` swallowed RPC errors as "no events"; unknown event names now throw (web3 parity) - Election historical `blockNumber` queries were silently ignored (voter rewards at past epochs) - governance CLI commands no longer displayed on-chain event confirmations (ProposalExecuted / HotfixExecuted / HotfixApproved / Deposit) — restored, including the silently-dropped test snapshots - `isValidChecksumAddress` accepted all-lowercase addresses; sourcify proxy implementation address checksummed again - BigInt-safe JSON-RPC serialization in production providers Plus test-semantics restorations (weakened assertions, mocked-method-under-test), test-infra robustness (receipt waits, strict `evm_revert`), changeset corrections (contractkit correctly marked major with full breaking-change list), and documentation of behavior changes. Full audit trail (62 findings: 38 fixed, 12 refuted with evidence, the rest classified pre-existing/wontfix) lives in `.omc/ralph/pr-review-progress.md` on the working machine; findings are also traceable through the individual commit messages. ## Test plan - [x] Full workspace build green (all 23 packages) - [x] Full test suite: all packages green locally except known env-flaky timeouts under full parallel load (actions/keystores) and a pre-existing `election:activate --wait` snapshot-order flake that reproduces on the unmodified stack HEAD - [x] Anvil-backed suites green: contractkit 258/258, celocli 337 passed - [x] Live smoke tests: IPC provider against `anvil --ipc`, WebSocket provider against `wss://forno.celo.org/ws` - [ ] CI green on this PR --------- Co-authored-by: Pavel Hornak <pavel.hornak@clabs.co> Co-authored-by: Paul Lange <palango@gmx.de>
2 participants
Stack
Changes
rpc-caller.ts,celo-transaction-object.ts,tx-result.tscontract-types.ts(CeloContract<TAbi>),viem-abi-coder.ts,wallet-adapter.tsconnection.tsinternals to use viem clientutils/— native bigint insolidity.ts,signatureUtils.ts,ecies.ts@ethereumjs/*dependenciesbuffer-equal-constant-timefor Node 25 compatibilityyarn.lockPart of the web3 → viem migration. No CI requirement on this PR.
PR-Codex overview
This PR focuses on refactoring the codebase to improve type safety, remove deprecated features, and transition from
web3toviemfor contract interactions. It also enhances logging and adjusts transaction handling for better performance and clarity.Detailed summary
web3.viemfor contract interaction, replacingweb3methods.anytypes.viemconventions.console.infowithdebug.declarationMapto TypeScript configurations for better debugging.viemimplementation and removeweb3dependencies.