Skip to content

docs: [low] stop repeating the review level in PR descriptions - #5367

Open
rootulp wants to merge 1 commit into
mainfrom
claude/hopeful-meitner-ki96rr
Open

rootulp wants to merge 1 commit into
mainfrom
claude/hopeful-meitner-ki96rr

Conversation

@rootulp

@rootulp rootulp commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

The PR title already carries the review level tag, so repeating it in the description is redundant.

  • CLAUDE.md: replace the "repeat the tag in the description" rule with "don't repeat it".
  • CONTRIBUTING.md and .github/pull_request_template.md: drop the matching instruction so they don't contradict CLAUDE.md.

Generated by Claude Code

The PR title already carries the review level tag, so repeating it in
the description is redundant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KLJRT3NXXGenr2fWnJCtgb
@rootulp rootulp self-assigned this Oct 23, 2026
@rootulp
rootulp marked this pull request as ready for review October 23, 2026 22:56
@rootulp
rootulp requested a review from a team as a code owner October 23, 2026 22:56
@rootulp
rootulp requested a review from walldiss October 23, 2026 22:56
@rootulp
rootulp enabled auto-merge October 23, 2026 22:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T22:57:19.603769Z be6a159 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-23T22:57:56.509406Z be6a159 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.77%. Comparing base (f197272) to head (be6a159).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5367   +/-   ##
=======================================
  Coverage   38.77%   38.77%           
=======================================
  Files         323      323           
  Lines       22459    22459           
=======================================
  Hits         8708     8708           
+ Misses      12706    12705    -1     
- Partials     1045     1046    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] Safe to merge. The three documents consistently remove the description-tag requirement while preserving the existing title-tag requirement.

Summary

This PR stops asking contributors to repeat the review-level tag in PR descriptions.

  • PR guidance now keeps the review-level tag in the title only.

The updated instructions are consistent, and targeted checks confirmed that the existing title-format checks still work without a description tag. No actionable issues were found. This documentation-only change is safe to merge.

Reviews (1) · Last reviewed commit: "docs: [low] stop repeating the review le..." · Reviewed by Greptile

rootulp commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Tastora E2E / TestLightRestartTestSuite fails on this PR, including on one re-run. The cause is not in this PR, which only edits three Markdown files.

  • After the light node container restarts, SamplingStats reports isRunning=false, and DAS.WaitCatchUp at light_restart_test.go:80 then blocks until the 6-minute test context expires (context deadline exceeded).
  • The same suite fails on unrelated PRs today: run 40029073611 on ci(deps): [medium] sign Dependabot tidy commits through GitHub #5365 and run 39960580001 on the go-mod-parity PR, also on its re-run. The other 12 Tastora suites pass.

No fix PR exists yet, so there's nothing to port here. Fixing it means finding out why the DASer doesn't resume after a light node restart. That's a separate change and doesn't belong in this docs PR.


Generated by Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant