Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5366 +/- ##
==========================================
+ Coverage 38.77% 39.36% +0.59%
==========================================
Files 323 323
Lines 22459 22463 +4
==========================================
+ Hits 8708 8843 +135
+ Misses 12706 12553 -153
- Partials 1045 1067 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
[Medium impact] The checked blob submission and authentication paths behaved as intended, with no outstanding issues blocking merge.
|
Fixes #4625.
blob submit --input-file blobs.jsonnow works without placeholder positional arguments or a panic. Mixed file/positional input and excess arguments return errors.blob submit <namespace> -reads raw bytes from stdin, preserving binary data and newlines without hex decoding.Remote RPC commands using
--urlno longer require a dummy token. Explicit--tokenand--node.storeauthentication still work, and local node discovery remains available when--urlis omitted. Calls using--urlthat previously relied on automatically discovered local credentials must now specify--tokenor--node.store. Servers still enforce their own authentication.Review level: [high] — changes CLI authentication selection and blob submission input handling.
Validation:
./cmd,./nodebuilder/blob/cmd,./nodebuilder/state/cmd, and./nodebuilder/share/cmd.go test -race ./cmd ./nodebuilder/blob/cmd -count=1../cmd/celestiaand exercised the binary against a local HTTP RPC server: file-only submission, binary stdin, unauthenticated requests, explicit tokens, and existing hex input.git diff --checkpassed.go vet ./...reports the pre-existing discarded timeout cancellation atcmd/rpc.go:86(formerly line 88).8bfb8cbd: Linux and macOS unit suites, coverage, all nine integration jobs, all 13 Tastora E2E suites, lint/imports, dependency checks, and OpenRPC generation. CI run, E2E run.