feat: add emphasized typescale and fix letter-spacing spec bugs#4920
Open
adrcotfas wants to merge 1 commit into
Open
feat: add emphasized typescale and fix letter-spacing spec bugs#4920adrcotfas wants to merge 1 commit into
adrcotfas wants to merge 1 commit into
Conversation
|
Hey @adrcotfas, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here. |
adrcotfas
force-pushed
the
@adrcotfas/refactor/tokens_typography
branch
2 times, most recently
from
919f3be to
8ce4e46
Compare
This was referenced May 5, 2026
satya164
reviewed
May 9, 2026
Member
satya164
left a comment
satya164
left a comment
There was a problem hiding this comment.
This PR has conflicts and includes other changes, so I'll defer review until after rebase.
adrcotfas
force-pushed
the
@adrcotfas/refactor/tokens_shape
branch
from
dc37d76 to
ac5ab0e
Compare
Adds 15 *Emphasized entries per M3 Design Kit: Display/Headline/TitleLarge/Body use Medium (500), TitleMedium/TitleSmall/Label use Bold (700). Adds weightBold to ref.typeface. Fixes displayLarge letterSpacing (0 -> -0.25) and bodyLarge letterSpacing (0.15 -> 0.5).
adrcotfas
force-pushed
the
@adrcotfas/refactor/tokens_typography
branch
from
8ce4e46 to
c4dc2f1
Compare
Collaborator
Author
Rebase is done on top of fixes from the upstream branches. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adds 15 *Emphasized entries per M3 Design Kit: Display/Headline/TitleLarge/Body use Medium (500), TitleMedium/TitleSmall/Label use Bold (700). Adds weightBold to ref.typeface. Fixes displayLarge letterSpacing (0 -> -0.25) and bodyLarge letterSpacing (0.15 -> 0.5).
Related issue
See https://www.notion.so/callstack/React-Native-Paper-Foundation-for-MD3-Expressive-34c5d027c0f880edba3df107cd35946f?source=copy_link
Merge order:
Test plan
yarn typescript-- no new type errorsyarn test-- all tests pass