Skip to content

follow up expose ranker knobs (rankerconfig) via CachePolicy - #192

Open
heymrbox wants to merge 2 commits into
mainfrom
heymrbox/cac-81-cac-53-follow-up-expose-ranker-knobs-rankerconfig-via
Open

follow up expose ranker knobs (rankerconfig) via CachePolicy#192
heymrbox wants to merge 2 commits into
mainfrom
heymrbox/cac-81-cac-53-follow-up-expose-ranker-knobs-rankerconfig-via

Conversation

@heymrbox

Copy link
Copy Markdown
Contributor

Summary

Linked issues

CAC-81

Checklist

Vendor-neutral naming (required — see CONTRIBUTING.md)

  • No oci / oracle / *.oci.com / oraclecloud.com in any API group, CRD group, proto package, gRPC service/package, Kubernetes namespace, image registry, Helm chart, or Go module path.
  • Any cloud-specific (incl. OCI) integration lives in an isolated, optional adapter (pkg/adapters/.../) — never in core controllers, CRD types, the proto contract, or default config.
  • No Oracle/OCI domain or namespace in sample manifests, README, or default values.
  • Pre-commit naming guard passed (make install-hooks once, then it runs on every commit).

Quality

  • Every human-authored commit includes a matching DCO Signed-off-by: trailer (git commit --signoff).
  • make reuse-lint passes (SPDX headers and licensing metadata are complete).
  • make build and make test pass locally.
  • make lint clean (gofmt + go vet).
  • make manifests generate produces no drift (generated code committed).
  • New/changed behavior has unit tests.
  • Operator-facing change (CRD columns/fields, .status, CLI, gRPC/HTTP, install bundle/RBAC, samples)? If so, the install-smoke gate asserts it (see CONTRIBUTING.md).
  • CI is green.

Contracts (only if touching CRDs or proto)

  • Change matches the tech spec (or the spec is updated in the same PR).
  • Backward compatibility considered for v1alpha1 consumers (engines, gateway clients).
  • If proto/ changed, docs/design/grpc-contract.md is updated to match (the pre-commit hook enforces this).
  • If CRD API types (api/v1alpha1/*_types.go) or the proto contract changed, the documentation is updated to match — the docs site (site/) and/or the design docs (docs/). CI enforces this (make verify-docs-sync); add the no-docs-needed label to waive a genuinely doc-exempt change.

Signed-off-by: Weiwei Zheng <heymrbox@gmail.com>
Signed-off-by: Weiwei Zheng <heymrbox@gmail.com>
@linear-code

linear-code Bot commented Aug 26, 2026

Copy link
Copy Markdown

CAC-81

CAC-53

@github-actions

Copy link
Copy Markdown

Codex review

Files reviewed

  • Root
    • Makefile [reviewed]
    • go.mod [reviewed]
  • api/v1alpha1/
    • cachepolicy_types.go [reviewed]
    • remaining_crds_types_test.go [reviewed]
    • zz_generated.deepcopy.go [skipped — generated]
  • config/crd/bases/
    • inferencecache.io_cachepolicies.yaml [skipped — generated]
  • config/samples/
    • cache_v1alpha1_cachepolicy.yaml [reviewed]
  • docs/concepts/
    • cachepolicy-tuning.md [reviewed]
  • docs/design/
    • lookuproute-ranking.md [reviewed]
    • policy-crds.md [reviewed]
    • policy-propagation.md [reviewed]
  • docs/reference-stack/scripts/
    • default_install_smoke.sh [reviewed]
  • docs/reference/
    • reason-codes.md [reviewed]
  • internal/controller/
    • controlplane_controller.go [reviewed]
    • controlplane_controller_test.go [reviewed]
  • internal/controlplaneapi/
    • contracts_test.go [reviewed]
    • policy.go [reviewed]
  • internal/index/
    • index.go [reviewed]
    • lookup.go [reviewed]
    • ranker_resolver_test.go [reviewed]
    • ranking.go [reviewed]
    • types.go [reviewed]
  • internal/server/
    • policy.go [reviewed]
    • ranker_policy_test.go [reviewed]
    • server.go [reviewed]
    • tenant_quota_test.go [reviewed]
  • internal/webhook/v1alpha1/
    • cachepolicy_webhook.go [reviewed]
    • cachepolicy_webhook_test.go [reviewed]
  • site/content/en/docs/concepts/
    • cachepolicy.md [reviewed]
  • site/content/en/docs/reference/
    • crd-api.md [reviewed]
    • reason-codes.md [reviewed]

Findings

Blocking

None.

Should-fix

None.

Nit

None.

Per-category coverage

  1. Vendor-neutral naming: Clean
  2. Contract & spec / docs sync: Clean
  3. gRPC fail-open semantics: Clean
  4. Quality (tests / error wrapping / package placement / generated drift): Clean

Verdict

approve

@codecov

codecov Bot commented Aug 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@heymrbox heymrbox changed the title Heymrbox/cac 81 cac 53 follow up expose ranker knobs rankerconfig via follow up expose ranker knobs (rankerconfig) via CachePolicy Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant