fix(email-composer): hide template buttons when templates are disabled#642
Open
Mirrrek wants to merge 1 commit into
Open
fix(email-composer): hide template buttons when templates are disabled#642Mirrrek wants to merge 1 commit into
Mirrrek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the template buttons and keyboard shortcut from
EmailComposerwhen thetemplatesEnabledfeature gate is disabled. See #639 for more information.Changes
Use Template&Save as Templatebuttons are only rendered whentemplatesEnabledis true.templatesEnabledis false.Related Issues
Fixes #639
Type of Change
Checklist
npm run typecheck && npm run lintand there are no errorsnpm run build)locales/) if my changes affect user-facing textScreenshots / Demo
Before (template buttons visible in composer bottom bar):

After (template buttons removed):

Notes for Reviewers
I'm getting lint warnings from other parts of the code and a Next.js runtime error
Failed to create address book. None of those are caused by the changes.