feat(email-list): add bulk Not-Spam action to selection toolbar in junk#637
Open
shukiv wants to merge 1 commit into
Open
feat(email-list): add bulk Not-Spam action to selection toolbar in junk#637shukiv wants to merge 1 commit into
shukiv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a Not spam button to the bulk-selection toolbar, shown only when viewing a junk folder — alongside the existing mark-read / mark-unread / delete actions. Selecting spam messages and clicking it un-junks them in one shot, instead of having to open the context menu.
Why
The batch un-spam action already exists (
onBatchUndoSpamin the context menu); this just surfaces it as a first-class toolbar icon where it's most useful. Matches the discoverability of the other bulk actions.Implementation
handleBatchUndoSpamhandler inemail-list.tsx, reusing the existingbatchUndoSpamstore action and the same success/error toasts as the context-menu path.ShieldCheckicon), gated oneffectiveMailboxRole === 'junk'(works for the aggregate "All Junk" view too).context_menu.not_spamlabel — no new i18n keys (already translated in all locales).Testing
tscclean; lint clean (no new warnings)