update query from POD type in pgsql  #88

Activity

1. SingingBush commented on Feb 11, 2020

   

   SingingBush

   on Feb 11, 2020

   Collaborator

   More actions

   The error is weird as there's no column called Test, I suspect it's simply a misleading error and that the cause of the problem is that user is a reserved word that should be surrounded with ".

   I tested the SQL with https://www.db-fiddle.com/f/hroWDeZav3cgHSkwV8qUFQ/0

   and found that I certainly needed to use double quotes around the tables name:

   CREATE TABLE "user" (
     id INT PRIMARY KEY NOT NULL,
     name TEXT NOT NULL
   );
   
   INSERT INTO "user" (id, name) VALUES (1, 'Initial Value');
   
   UPDATE "user" SET name='Test' WHERE id=1;
   
   SELECT * FROM "user";
2. SingingBush

   added

   bug

   Postgres

   on Feb 11, 2020
3. Rogni commented on Feb 11, 2020

   

   Rogni

   on Feb 11, 2020

   Last edited by Rogni

   Author

   More actions

   okey. i create test database and run

   create table custom_table ( 
       id SERIAL PRIMARY KEY, 
       firstname TEXT,
       lastname TEXT
   );
   
   INSERT INTO custom_table(firstname,lastname) VALUES ('TestFirstname','TestLastname');
   

   in main.d

   import ddbc;
   static import config;
   import std.conv: to;
   
   
   private const string CONNECTION_URL = "postgresql://"~ config.HOST 
                               ~ ":" ~ to!string(config.PORT) ~"/"
                               ~ config.DATABASE ~ "?user="
                               ~ config.USER ~",password="
                               ~ config.PASSWORD ~ ",ssl=true";
   
   struct custom_table
   {
       size_t id;
       string firstname;
       string lastname;
   }
   
   
   int main(string args[]) {
       custom_table item;
       item.id = 0;
       item.firstname = "TestFirstname";
       item.lastname = "TestLastname";
       auto connection = createConnection(CONNECTION_URL);
       scope (exit) connection.close();
       auto statement = connection.createStatement();
       scope (exit) statement.close();
       update!custom_table(statement, item);
   
       return 0;
   }
   

   Error:

   2020-02-11T17:23:28.993:pgsqlddbc.d:executeUpdate:670 UPDATE custom_table SET firstname="TestFirstname",lastname="TestLastname" WHERE id=0;
   ddbc.core.SQLException@../../../.dub/packages/ddbc-0.5.1/ddbc/source/ddbc/drivers/pgsqlddbc.d(676): ERROR:  column "TestFirstname" does not exist
   LINE 1: UPDATE custom_table SET firstname="TestFirstname",lastname="...
   
4. Rogni commented on Feb 12, 2020

   

   Rogni

   on Feb 12, 2020

   Last edited by Rogni

   Author

   More actions

   why in update query used
   

   ddbc/source/ddbc/pods.d

   Line 1093 in cb72071

   string addUpdateValue(T)(string m) {

   
   ?
   why not use
   

   ddbc/source/ddbc/pods.d

   Line 1040 in cb72071

   string addFieldValue(T)(string m) {

   
   ?
5. buggins

   self-assigned this

   on Oct 29, 2026
6. buggins

   closed this as completedin #141on Oct 29, 2026
7. buggins

   added a commit that references this issue on Oct 29, 2026

   Fix SQL generated by POD insert and update (#141)

   ...

   df201b7