refactor(agent-tools): trim dead AgentChannel scaffolding to only doom_loop_hash#6535
Merged
Merged
Conversation
…m_loop_hash Removes the unused AgentChannel sealed trait and its supporting ChannelSinkError/ToolEventStart/ToolEventOutput/Sealed types (channel.rs, error.rs, sealed.rs), along with ToolDispatchError (error.rs) -- dead scaffolding from an abandoned dispatcher-extraction plan (issue #3516, closed) with zero implementors or consumers anywhere in the workspace. zeph-agent-tools now exposes only doom_loop_hash, its sole real production consumer (zeph-core's tool tier loop). Drops the now-unused futures/serde/serde_json/thiserror/tokio/tracing/ zeph-common/zeph-llm/zeph-tools dependencies and the sqlite/postgres feature forwarding they existed to support -- the crate now has zero workspace or external dependencies. Also corrects two stale cross-crate doc references to the trimmed crate in zeph-agent-context and zeph-durable. Closes #6480
github-actions
Bot
added
the
refactor
github-actions
Bot
added
documentation
bug-ops
enabled auto-merge (squash)
July 20, 2026 02:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zeph-agent-toolswas ~90% dead scaffolding from an abandoned crate-extraction plan (issue feat(core): extract zeph-agent-tools crate from zeph-core (Phase 2) #3516, closed): theAgentChannelsealed trait and its supporting types (ChannelSinkError,ToolEventOutput,ToolEventStart,ToolDispatchError,Sealed) had zero implementors or consumers anywhere in the workspace.channel.rs,error.rs,sealed.rsentirely; the crate now exposes onlydoom_loop_hash, its sole real production consumer (zeph-core's tool tier loop, now atagent/tool_execution/doom_loop.rs:19after the unrelated refactor(core): split tool_execution/tier_loop.rs into concern-scoped modules #6534 split).futures/serde/serde_json/thiserror/tokio/tracing/zeph-common/zeph-llm/zeph-toolsdependencies and thesqlite/postgresfeature forwarding — the crate now has zero workspace or external dependencies.zeph-agent-context,zeph-durable).zeph-agent-toolscrate (documented inCHANGELOG.mdunder### Removed).Test plan
cargo +nightly fmt --checkcargo clippy --profile ci --workspace --all-targets --features "desktop,ide,server,chat,pdf,scheduler,testing" -- -D warningscargo nextest run --config-file .github/nextest.toml --workspace --features "desktop,ide,server,chat,pdf,scheduler" --lib --bins(14796 passed, 0 failed)RUSTFLAGS="-D warnings" RUSTDOCFLAGS="--deny rustdoc::broken_intra_doc_links" cargo doc --no-deps --workspace ...)cargo test --doc -p zeph-agent-toolsdoom_loop_hashand its call site are byte-for-byte unchanged.local/testing/coverage-status.mdCloses #6480