fix(preview): green accent on Remix previews + overlay/localization host#22
Merged
Merged
Conversation
Add `accent: .green` to the FortalScope of every Remix component preview (callout, card, checkbox, divider, icon_button, menu, progress, radio, spinner, tooltip) so they match the accent used by accordion, giving the docs a consistent green-accented look. Also fix the embedded multi-view preview host: - helpers.dart: give the standalone Scaffold a dark background (#1A1A2E) matching the host container so small centered demos don't show a light-grey backdrop. - multi_view_app.dart: wrap embedded previews in Localizations + DefaultWidgetsLocalizations (required by RawRadio) and an Overlay ancestor (required by menu/select/tooltip popups). The standalone runMixApp path gets these from MaterialApp; the embedded path must provide them explicitly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two related fixes to the Flutter docs previews:
1. Consistent green accent
Adds
accent: .greento theFortalScopeof every Remix component preview so they match the accent already used by the accordion preview. Previously most previews fell back to the default accent, making the docs look inconsistent.Affected previews: callout, card, checkbox, divider, icon_button, menu, progress, radio, spinner, tooltip.
2. Embedded preview host fixes
helpers.dart— give the standaloneScaffolda dark background (#1A1A2E) matching the host container, so small centered demos (menu, tooltip, select…) no longer show a light-grey backdrop.multi_view_app.dart— wrap embedded previews inLocalizations+DefaultWidgetsLocalizations(required byRawRadio, used byRemixRadio) and anOverlayancestor (required by menu/select/tooltip popups mounted viaRawMenuAnchor/OverlayPortal). The standalonerunMixApppath gets these fromMaterialApp; the embedded multi-view path must provide them explicitly.Testing
build_web_previews.sh) — 70 entries, manifest check OK.🤖 Generated with Claude Code