test(render): cover 180-degree rotation preserving orientation - #154
Open
UnrulyBad11 wants to merge 1 commit into
Open
test(render): cover 180-degree rotation preserving orientation#154UnrulyBad11 wants to merge 1 commit into
UnrulyBad11 wants to merge 1 commit into
Conversation
is_portrait_source() only swaps width/height for quarter-turn rotations (90/270); a half-turn (180) should leave a landscape source landscape. Add a regression test for that case. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_portrait_source() only swaps width/height for quarter-turn rotations (90/270); a half-turn (180) should leave a landscape source landscape but that path wasn't covered by a test. This adds a regression test for it.
🤖 Generated with Claude Code
Summary by cubic
Adds a regression test for
is_portrait_source()to verify a 180-degree rotation does not change orientation. The function only swaps width/height for quarter-turn rotations (90/270), but that half-turn path wasn't covered by a test.Written for commit 1b33757. Summary will update on new commits.