test: add coverage for helpers/pack_transcripts.py - #142
Open
Ghost-outthere wants to merge 1 commit into
Open
Conversation
format_time, format_duration, and group_into_phrases had no tests, unlike the render helpers. Follows the same importlib-load pattern as tests/test_render_orientation.py.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
helpers/pack_transcripts.pyhad no test coverage, unlikehelpers/render.pywhich hastests/test_render_fps.pyandtests/test_render_orientation.py.format_time,format_duration, andgroup_into_phrases(silence-based and speaker-change splitting, audio-event wrapping, punctuation spacing).importlib-load pattern fromtests/test_render_orientation.pyso no packaging/install step is needed to run it.Test plan
python -m unittest discover -s tests -v— all 28 tests pass (16 existing + 12 new) on a clean checkout.Summary by cubic
Adds unit tests for
helpers/pack_transcripts.pycovering its three pure functions (time formatting, duration formatting, and phrase grouping) and verifies behavior like silence-based splitting, speaker changes, audio events, and punctuation spacing. The tests use the same importlib-load pattern as existing render tests, so no packaging step is needed; all 28 tests pass.Written for commit 1013ddc. Summary will update on new commits.