Repository navigation
Instant::toISOString() is not RFC 3339 compliant #110
Description
Instant::toISOString() / ZonedDateTime::toISOString returns value that is not RFC 3339 compliant, because it will omit seconds, when its value is zero.
This is causing portability issues, for example, such value is not accepted by java.time.Instant.parse.
Reacted by Jan Nedbal, Benjamin Morel, Michael Olšavský and Choraimy Kroonstuiver
Activity
BenMorel commentedon Jul 6, 2024
Good point, thanks for reporting it @JanTvrdik!
I'm surprised to see that the behaviour is different for
LocalDateTimeandLocalTime: sandbox.This is probably the source of confusion when I first implemented
ZonedDateTime::__toString(), where I just concatenated the output of theLocalDateTimewith the timezone.I'll work on a fix, however this will target version
0.8.0as this is technically a BC break.What about parsing, should we force seconds as well? I'm leaning towards yes.
JanTvrdik commentedon Jul 7, 2024
Java allows missing seconds when parsing
ZonedDateTime,LocalDateTimeandLocalTime. The missing seconds are allowed by ISO 8601. You also have the problem, that you would be unable to parse string that were generated bybrick/date-time< 0.8. So overall I think it's better to keep the parser unchanged.BenMorel commentedon Sep 30, 2026
Released as 0.10.0.