You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I could have sworn I had written something in the readme about it, but apparently I didn't.
For reference for anyone finding this before I actually get around to adding it to the docs:
We ran into an issue #16 which is that number values returned from Datadog were larger than JSON could support, so there was lose of precision/overflowing for large numbers.
The solution was to utilize json-bigint which utilizes bignumber.js to support larger numbers in JSON.
The problem with this is that the format that bignumber.js stores numbers in isn't the most intuitive manner.
Hard to know for sure, my best guess is for backwards compatibility, since they have always been numbers, and are stored as numbers on their end. The numbers are actually fine, if you can parse an int64.
We could probably coerce the ids into strings here in this library, but we'd probably still have to use json-bigint for parsing first anyways.
Activity
jaredallard commentedon May 26, 2016
Is there a reason Datadog doesn't return string representation of these numbers? Seems like an odd choice...
brettlangdon commentedon May 26, 2016
Hard to know for sure, my best guess is for backwards compatibility, since they have always been numbers, and are stored as numbers on their end. The numbers are actually fine, if you can parse an int64.
We could probably coerce the ids into strings here in this library, but we'd probably still have to use
json-bigintfor parsing first anyways.¯_(ツ)_/¯