Comment out the Lift plugin in the serverless.yml stub - #212
Merged
Merged
Conversation
The plugin was enabled while all the constructs are commented out, and its comment says "Uncomment the Serverless Lift plugin if you use constructs". Deploying the published serverless.yml failed unless Lift was installed:
osls plugin "serverless-lift" not found.
The comment now also says how to install Lift.
mnapoli
force-pushed
the
aws-onboarding-stub
branch
from
September 26, 2026 13:38
053a662 to
93e1c38
Compare
mnapoli
changed the title
mnapoli
added a commit
to brefphp/bref
that referenced
this pull request
Sep 26, 2026
…less.yml brefphp/laravel-bridge#212 comments out the plugin in the published serverless.yml, so the getting started no longer needs Lift. The guides that use constructs tell to uncomment it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while redoing the onboarding from scratch (fresh
laravel newapp, following the Laravel getting started).The published
serverless.ymlenabled theserverless-liftplugin while all the constructs are commented out, and the comment above it says "Uncomment the Serverless Lift plugin if you use constructs". Nothing in the getting started installs Lift, so the very first deploy failed before reaching AWS:The suggested command does not even exist for Bref Cloud users, who don't install osls globally (
bref deployrunsnpx osls@3).The plugin line is now commented out, like the constructs, and the comment says how to install Lift. Checked that the stub packages without warnings when Lift is not installed (the empty
constructs:key is fine).The docs guides that enable constructs (queues, file storage, website assets) tell to install Lift and uncomment this line: brefphp/bref#2187. Both should be released together.