fix: tighten up shell escaping to handle some edge cases - #1632
Merged
Conversation
✅ Deploy Preview for dpp-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When passing command line parameters to a bourne style shell using
dpp::utility::exec(), the user could be misled to believe DPP does escaping of ` symbols,$(), etc (it did not).This PR adds support for escaping that properly blocks those bourne behaviours in Linux and other similar operating systems, so that it is a bit more friendly.
Note, this does not absolve the library user of NOT passing user crafted data into
dpp::utility::exec(). It is not our job to protect the library users from stupidity.Windows doesn't need this patch, as
std::quoted()will suffice there.Code change checklist