Implement Derived, Read-Only Settings (to support audio input override)#28
Open
boatmeme wants to merge 12 commits into
Open
Implement Derived, Read-Only Settings (to support audio input override)#28boatmeme wants to merge 12 commits into
boatmeme wants to merge 12 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of the observed interaction between the Audio Input Override setting, the Input setting, and a third, as-yet-unidentified byte (assuming it is the true "audio input" value), I saw the need for a concept of a "derived" setting abstraction, which can take the values of multiple, distinct, public-facing settings and use that to calculate a value for its own byte location(s).
I believe it makes sense to build that on top of the existing
RetroTinkReadOnlySettingabstraction as these settings/values aren't directly settable by the interface anyway.After adding the abstraction, I was then able to successfully implement all of the audio settings, including the read-only, derived setting,
audio.input.