fix: strip GIT_* env vars from git subprocesses - #42
Closed
alecthomas wants to merge 1 commit into
Closed
alecthomas wants to merge 1 commit into
alecthomas wants to merge 1 commit into
Conversation
lhm shells out to git to read and modify repository state. When it runs as a git hook -- or when its test suite is driven by an outer git invocation carrying -c overrides -- git exports GIT_DIR, GIT_CONFIG_PARAMETERS, and friends. Inherited by our child git processes, these silently redirect which repository is queried or rewrite the URLs git reports (e.g. url.<base>.insteadOf), so a command no longer reflects the directory we asked about. Route every git invocation through a helper that removes the entire GIT_ namespace, rather than blacklisting individual variables. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
Author
|
🤖 Closing — dropping the git-env hardening. The failing test was an artifact of a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lhm shells out to git to read and modify repository state. When it runs
as a git hook -- or when its test suite is driven by an outer git
invocation carrying -c overrides -- git exports GIT_DIR,
GIT_CONFIG_PARAMETERS, and friends. Inherited by our child git
processes, these silently redirect which repository is queried or
rewrite the URLs git reports (e.g. url..insteadOf), so a command
no longer reflects the directory we asked about.
Route every git invocation through a helper that removes the entire
GIT_ namespace, rather than blacklisting individual variables.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com