Polish onboarding avatar capture

[cynfria]

Summary

• polish the onboarding avatar editor layout, mode tabs, preview, and backdrop controls
• preserve the existing onboarding join-progress and resumable-profile navigation semantics
• add an explicit Try camera again action after camera startup failures while keeping onboarding avatar UI light-only
• share deterministic fake-camera setup and cover onboarding camera failure, retry, recording, review, and save via E2E

Testing

• pnpm check
• pnpm typecheck
• pnpm build
• pnpm exec playwright test tests/e2e/onboarding.spec.ts tests/e2e/animated-avatar.spec.ts — 44 passed
• pre-push desktop, mobile, Tauri, and Rust checks passed; the unrelated workspace ACP integration suite was flaky across two runs, failing a different timing-sensitive test each time (cancelled_turn_with_usage_emits_notification_before_response, then steer_folds_into_active_turn_without_cancelling)

[wesbillman]

This is not yet safe as UI-only polish.

The production diff changes camera behavior: the onboarding modal passes autoStartCamera, and entering the Animated tab now immediately selects a source and calls getUserMedia; it also adds a new retry path after startup failure. That changes permission timing and capture lifecycle rather than only presentation. The 13-file / 1,543-line diff also refactors shared profile-editor components used outside onboarding, which makes the regression surface much larger than this onboarding polish requires.

Please keep the existing camera-start/selection behavior and narrow the change to onboarding presentation (or split the camera lifecycle work into a separately reviewed behavior PR). The current CI is green and the head is based on current main; this request is about scope and behavior safety, not test status.

[wesbillman]

Follow-up after product clarified that justified behavior changes are in scope: I re-reviewed this as a complete UX change. The behavioral delta is limited to the onboarding avatar modal: selecting Animated now auto-selects the preferred camera and requests camera access, and a failed request exposes an explicit retry. Camera cleanup, recording, review, upload/apply, profile save, and onboarding navigation remain on the existing paths; the focused E2E covers failure → retry → record → review → save. The shared-file changes are largely presentation-specific extraction guarded by presentation="onboarding-modal".

I consider that behavior coherent and adequately covered, so my scope objection is cleared. I am not approving this stale head: current main moved after its green run. Please rebase and rerun CI; I will gate the rebased head.

[wesbillman]

Re-review complete on head 2afef64: the original behavior/scope concern is cleared, all applicable CI is green, and the branch is mergeable. Approving under the owner’s explicit decision to accept the known stale-base risk.