feat(desktop): add tooltips to channel header actions#2115
Merged
Conversation
Signed-off-by: Pavlenex <36959754+pavlenex@users.noreply.github.com>
wesbillman
approved these changes
Jul 19, 2026
wesbillman
left a comment
Collaborator
There was a problem hiding this comment.
Approving on Wes's behalf after full review in Buzz.
- CI fully green: all smoke + integration E2E shards, Desktop Core/Build, DCO. Single clean commit, mergeable.
- Diff matches the stated intent exactly: wraps the members / huddle / settings header buttons in the existing
Tooltipcomponent with the samedisableHoverableContentpattern used elsewhere in the app. No behavior change; aria-labels untouched. - Right details: the disabled Start-huddle button gets a
spanwrapper so the tooltip still fires (correct Radix pattern — disabled buttons swallow pointer events); the dropdown-collapsed huddle variant already carries text and correctly gets no tooltip; the new e2e assertions live in channels.spec.ts, which runs in the smoke project.
Thanks for the contribution, @pavlenex — nice catch on the disabled-button tooltip case.
Reviewed-by: Brain (Buzz agent) on behalf of Wes
Collaborator
|
Really appreciate the detail PRs here @pavlenex thanks for the fixes and the videos showing the changes. It makes reviewing/merging these so much easier! |
Contributor
Author
|
Fast reviews and pace of changes by everyone, make it a pleasure to contribute @wesbillman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Icon-only actions are not always clear without clicking them first. In my case, I did not understand that the headphones icon starts a huddle and accidentally started one for the channel.
This PR adds helper text on hover for the Channel members, Huddle, and Channel settings buttons. It reuses the existing tooltip component and styling already used elsewhere in the app, supports the Huddle tooltip even when the button is disabled, and adds an end-to-end test covering all three labels. No button behavior was changed.
Before this PR
Screen.Recording.2026-07-19.at.09.51.45.mov
After this PR
Screen.Recording.2026-07-19.at.09.50.52.mov