Recover stale community entries#2114
Closed
baxen wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Bradley Axen <baxen@squareup.com> Signed-off-by: Bradley Axen <baxen@squareup.com>
Contributor
Author
|
Superseded by the foundational state-model approach agreed in the Buzz design thread: make community selection nullable, provide an always-renderable Community Home, and separate saved configuration, current-session usability, and onboarding operations. The stale-entry replacement/transaction-retargeting mechanism in this PR couples recovery to the wrong event. We will preserve the original wedge as a transition regression and reuse the scoped cache-cleanup behavior in the replacement implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Changing identities can leave Desktop with a stale local community entry and a pending onboarding transaction. When the correct saved community uses the requested relay URL, the duplicate-relay guard currently leaves the user with no in-app recovery path.
What
Risk Assessment
Low — the repair requires confirmation and only changes local Desktop state. It does not mutate either relay or the persisted Nostr identity.
Verification
pnpm typecheckpnpm checkGenerated with Codex