Skip to content

feat(desktop): polish community access request#2112

Merged
wesbillman merged 1 commit into
mainfrom
request-community-polish
Jul 19, 2026
Merged

feat(desktop): polish community access request#2112
wesbillman merged 1 commit into
mainfrom
request-community-polish

Conversation

@cynfria

@cynfria cynfria commented Jul 19, 2026

Copy link
Copy Markdown
Contributor

Why

Bring the first-community access request step in line with the approved onboarding design while preserving the existing join flow.

What

  • Present public-key sharing and community URL entry as two centered steps
  • Match the approved typography, translucent fields, focus treatment, and stacked footer actions
  • Preserve responsive wrapping, accessibility names, validation, copy, submit, and back behavior

Risk Assessment

Low — this is a styling-only update to one onboarding view with no backend, persistence, or navigation behavior changes.

References

  • just ci passed locally
  • Targeted onboarding integration E2E: 3/3 passed
  • Manual verification in the live worktree Tauri instance

Generated with Peppermint Butler

Co-authored-by: npub19x6jnl6rhepymwyl2xlltz3ce7rfg2ktllle3g2vu59n3s490k8s9n40l3 <29b529ff43be424db89f51bff58a38cf86942acbffff98a14ce50b38c2a57d8f@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: npub19x6jnl6rhepymwyl2xlltz3ce7rfg2ktllle3g2vu59n3s490k8s9n40l3 <29b529ff43be424db89f51bff58a38cf86942acbffff98a14ce50b38c2a57d8f@sprout-oss.stage.blox.sqprod.co>
@wesbillman

Copy link
Copy Markdown
Collaborator

Safety review: the production diff is confined to WelcomeSetup.tsx; submit/validation/copy/back handlers and onboarding calls are preserved. The changes are presentation, copy, and accessibility semantics only. Current-head CI is green. I am withholding approval only because the branch is one commit behind current main; please rebase/update and let CI rerun, then this is ready for the approval gate.

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. The production diff remains confined to WelcomeSetup.tsx; validation, submit, clipboard, navigation, and onboarding calls are preserved. The footer submit button remains associated with the same form via form="welcome-join-form". Current head CI is green, intervening main changes do not overlap this file, and GitHub reports the PR mergeable.

@wesbillman
wesbillman marked this pull request as ready for review July 19, 2026 15:48
@wesbillman
wesbillman requested a review from a team as a code owner July 19, 2026 15:48
@wesbillman
wesbillman merged commit 860263b into main Jul 19, 2026
25 checks passed
@wesbillman
wesbillman deleted the request-community-polish branch July 19, 2026 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants