fix(doctor): tie update badges to their binary and label bundled ACPs#879
Merged
Conversation
Render each update badge directly under the path of the binary it describes (main CLI vs ACP bridge) instead of stacking both badges after both paths, so a main-CLI update can no longer read as a nag about the bridge. When the resolved bridge lives in the app's bundled ACP tools dir, show "ACP bundled with Staged" instead of the app-internal resource path. A new optional `bundled` field on AgentVersionInfo carries this; the doctor crate never sets it — the app stamps it post-report in mark_bundled_bridges by prefix-matching bridge paths against the same dir apply_bundled_tools_env injects into the doctor PATH. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doctor rows previously collected all update badges into one list rendered after both path lines, so a bridge update badge could appear visually attached to the wrong binary. Bundled ACP bridges also displayed their raw app-internal resource path, which read as a user install.
path, bridge underbridgePath) instead of a combined list at the end of the row.bundledflag toAgentVersionInfoin the doctor crate. The crate never populates it — the embedding app stamps it after checks run.apply_bundled_tools_envinjects into PATH).Testing
🤖 Generated with Claude Code