feat(acp): support latest ACP session metadata#861
Merged
Merged
Conversation
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Record ACP message chunk IDs, usage updates, and prompt response usage as hidden session_messages rows while preserving legacy transcript filtering. Expose a query path for ACP metadata rows through Tauri and web commands so richer rows can be retrieved deliberately without changing current UI rendering. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Send ACP session/cancel before process teardown when a session id is available, answer cancelled permission requests with the ACP cancelled outcome, and map cancelled stop reasons into Staged interrupted completions. Use ACP message and tool IDs from existing session_messages metadata to bound resume replay before falling back to legacy role/content matching. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Render ACP tool status, structured inputs and outputs, diffs, locations, usage, plans, config selectors, and slash command discovery from existing session_messages metadata. Route ACP permission requests through the Staged UI instead of auto-selecting the first option, while preserving legacy fallback behavior for non-interactive clients. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Keep ACP permission option kinds typed in the wrapper and centralize the autoapproval helper so reject kinds are never selected just because their label contains allow. Update Staged to reuse the shared helper and add regressions for Don't allow and Disallow reject options. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Hide usage, mode, configuration, and slash command ACP metadata rows from the chat transcript while keeping plan metadata visible. Remove the right-aligned status label from chat tool call headers; status remains indicated by the icon and expanded details. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Carry the ACP tool call id through result persistence so interleaved ToolCallUpdate content updates separate transcript rows. Persist the tool call id on result rows for structured replay boundaries and add a regression for alternating tool result updates. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Short-circuit ACP resume replay when persisted history has no non-user replay target, while still transitioning the handler before the next prompt. Add a regression for user-only replay boundaries. Signed-off-by: Matt Toohey <contact@matttoohey.com>
Use ACP message IDs when visible projection rows have them, and otherwise consume concrete visible row occurrences instead of dropping every matching role/content pair. This preserves repeated user or assistant messages as replay boundaries while still avoiding duplicate chunk-backed projections. Signed-off-by: Matt Toohey <contact@matttoohey.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 523f75c7a2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Signed-off-by: Matt Toohey <contact@matttoohey.com>
Signed-off-by: Matt Toohey <contact@matttoohey.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary