Add High Contrast door setting#362
Merged
Merged
Conversation
…rs to include pause map (and rename to Vibrant)
nn357
marked this pull request as ready for review
July 15, 2026 03:15
blkerby
requested changes
Jul 15, 2026
Contributor
Author
|
Should be ok now, rather than swapping the palettes around on the fly in assembly, just start with the correct palettes. :) |
blkerby
reviewed
Jul 15, 2026
Comment on lines
+562
to
+563
| lda $b6f04c | ||
| sta $7ec0ec ; pb doors |
Owner
There was a problem hiding this comment.
This doesn't seem right? Above we already have
lda $B6F0EC
sta $7EC0EC
Contributor
Author
There was a problem hiding this comment.
oh maybe it's updating it from the other copy of the pallete, i can probably take that out then!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the alternate theme to "Vibrant".
Both High Contrast and Vibrant now also change the door lock colors in the pause menu to reflect the alternative door colors.