Skip to content

Timex.week_of_month doesn't specify week start #791

Description

@tisdall

There's Timex.weekday/1 that assumes an iso-week and Timex.weekday/2 that allows you to specify the start of the week. I was surprised that Timex.week_of_month doesn't have a version that allows you to specify the start of the week. Also, the docs don't explicitly say that it's using a Monday week start (though it's typical to assume ISO8601 standards, it would still be good to explicitly state it).

Since there are functions that allow specifying different starts of the week, I think it makes sense that the docs at least specify which day of the week is used as the start for the calculation. Ideally there's a version that allows specifying the week start, though.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions