Skip to content

Fix replace_related allowing duplicate entities - #26048

Open
SkiFire13 wants to merge 3 commits into
bevyengine:mainfrom
SkiFire13:fix-replace-related-unique-entities
Open

SkiFire13 wants to merge 3 commits into
bevyengine:mainfrom
SkiFire13:fix-replace-related-unique-entities

Conversation

@SkiFire13

Copy link
Copy Markdown
Contributor

Objective

Solution

  • Collect into a EntityHashSet before replacing the underlying relationship target collection
  • This is NOT supposed to prevent Children or other relationship targets from containing duplicates, however it makes this less likely to happen by mistake.

Testing

  • Added a regression test

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant